Oh I did not see this was not marked as review-needed. Feel free to ignore my comments.

@ffaf1 I consider the review-needed label more of our manegerial stuff (to notify Matrix, review during the meetings, and such) rather than an interface for contributors. In practice (I find), when people don't want reviews, they put the PR in the draft state (mostly) because they don't know about the label. So, if the PR isn't in the draft state, it's safe to assume that it can be reviewed, I think.

"cabal.project plugin" looks confusing in the context of the Cabal repository. Please, replace all of its occurrences with "cabal.project HLS plugin" (esp. the changelog).

These instances are also useful for the hls-cabal-plugin, so perhaps a more general HLS is sufficient.

Looks like there's a couple of rebase conflicts that need to be fixed.

@ffaf1 I resolved your older comments: they were straightforward to address and this was done. We can now move forward.